Update README.jp.md #754
Merged
Update README.jp.md #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
reviewed
Mar 23, 2017
README.jp.md
Outdated
|
|
||
| シングルクォートは Slim に行をコピーしろと命じます (`|` と同様に) が, 単一行の末尾にスペースが追加されているかチェックします。 | ||
| シングルクォートは Slim に行をコピーしろと命じます (`|` と同様に) が, 末尾にスペースが（なければ）追加されます。 |
There was a problem hiding this comment.
Thanks for your PR :)
Slim 3.0.7 always appends trailing white space, even if original text has trailing white space.
So I feel "末尾にスペースが追加されます。" is better.
body
p
' This line does not have trailing white space.
p
' This line has trailing white space. $ slimrb sample.smil
<body><p>This line does not have trailing white space. </p><p>This line has trailing white space. </p></body>
There was a problem hiding this comment.
fixed.
Now Japanese readme is better than English one ;)
|
Can you rebase it to merge one commit? |
fix translation about single quote > Slim 3.0.7 always appends trailing white space, even if original text has trailing white space.
|
@yui-knk merged to 1 commit. plz check. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix translation about single quote