fix bug for istio locality illegal characters #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MouceL
reviewed
Jul 20, 2023
bin/publish.sh
Outdated
| @@ -102,7 +102,7 @@ for action in $actions; do | |||
| case "$action" in | |||
| build) | |||
| echo "go build submodules ${MOD}" | |||
| CGO_ENABLED="${CGO_ENABLED}" GOOS="${TARGET_GOOS}" GOARCH=${TARGET_GOARCH} go build -o manager.exe | |||
| CGO_ENABLED="${CGO_ENABLED}" GOOS="${TARGET_GOOS}" GOARCH=${TARGET_GOARCH} go build -o manager | |||
There was a problem hiding this comment.
I don't think this needs to be modified
With .ignore, avoid binary uploads.
There was a problem hiding this comment.
OK，I will remove it.
|
Not sure if there are other places where labels have been added by slime that haven't been validated. The current fix is effective for the problems encountered by #404. |
updated. @believening @MouceL |
believening
approved these changes
Jul 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #404