Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify message timestamp formatting #648

Merged
merged 1 commit into from Nov 27, 2022
Merged

Conversation

eggert
Copy link
Contributor

@eggert eggert commented Dec 15, 2021

  • slime-tests.el (slime-wait-condition): Use format-time-string rather
    than formatting by hand. This avoids relying on Emacs timestamp
    format, which is slated to change.

* slime-tests.el (slime-wait-condition): Use format-time-string rather
than formatting by hand.  This avoids relying on Emacs timestamp
format, which is slated to change.
@monnier
Copy link
Contributor

monnier commented Jan 10, 2022

Hmm.. important note: this is not the right commit to merge, because it has commit ID 146837d, whereas the commit that was mistakenly pushed to nongnu.git is commit 1923227. Please do:

git fetch git://git.sv.gnu.org/emacs/nongnu.git elpa/slime

then you can check

git show FETCH_HEAD

or

git show 1923227f54

NonGNU ELPA won't be able to be updated to new Slime releases until that commit is merged upstream :-(
So it's very important to merge that particular commit (if you don't like it, feel free to merge it but throw away the actual file changes).

@monnier
Copy link
Contributor

monnier commented May 3, 2022

Ping?
This problem is still preventing new releases of SLIME on NonGNU ELPA.

@luismbo
Copy link
Member

luismbo commented May 5, 2022

@monnier I don't understand how merging that commit fixes anything. The resulting history in slime.git would still be different from nongnu.git's, wouldn't it?

@monnier
Copy link
Contributor

monnier commented May 5, 2022

That nongnu.git is different is not a problem: it's the normal case whenever someone commits a change to Slime, after all. After that nongnu.git catches up with a "fast forward".

With this merge, slime.git would still be different, yes, but it would go back to being a normal kind of different, i.e. "strictly ahead" (because the head of nongnu.git would be included as an ancestor of the head of slime.git), which is the normal case which can be resolved trivially with a fast-forward.

@monnier
Copy link
Contributor

monnier commented Oct 31, 2022

Ping? NonGNU ELPA is trailing something like 30 commits behind slime.git now :-(

@stassats stassats merged commit ba29269 into slime:master Nov 27, 2022
@monnier
Copy link
Contributor

monnier commented Dec 31, 2022

Ping? Ping? NonGNU ELPA is now a year behind!

@stassats
Copy link
Member

Take it up with NonGNU then.

@pedro-w pedro-w mentioned this pull request Feb 5, 2024
@phikal phikal mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants