Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field data improvements #232

Merged
merged 28 commits into from
Mar 27, 2024
Merged

Field data improvements #232

merged 28 commits into from
Mar 27, 2024

Conversation

mloubout
Copy link
Member

@mloubout mloubout commented Feb 15, 2024

Lots of improvements for field data handling

  • 2D projection of segy coordinates along sailline and origin shift
  • Handle non-zero t0 in segy data (nsOrig)
  • Move all requires to Julia extensions (new standard since julia 1.9)
  • Fix parallel illumination computation and illumination reduction for limit_m
  • Add TimeGain (scaling by t^k) preconditioned for 2d->3D amplitude scaling
  • Fix CI that wasn't running tti/fs/visco

TODO:

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 80.63241% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 83.13%. Comparing base (05e9ff9) to head (d0aee53).

Files Patch % Lines
src/TimeModeling/Types/GeometryStructure.jl 83.46% 21 Missing ⚠️
src/TimeModeling/Utils/auxiliaryFunctions.jl 34.78% 15 Missing ⚠️
src/TimeModeling/Preconditioners/base.jl 45.83% 13 Missing ⚠️
src/TimeModeling/Utils/time_utilities.jl 83.33% 10 Missing ⚠️
src/TimeModeling/Preconditioners/utils.jl 0.00% 9 Missing ⚠️
ext/FluxJUDIExt.jl 0.00% 5 Missing ⚠️
src/TimeModeling/Modeling/propagation.jl 81.48% 5 Missing ⚠️
src/TimeModeling/Types/lazy_msv.jl 86.84% 5 Missing ⚠️
ext/ZygoteJUDIExt.jl 0.00% 4 Missing ⚠️
src/TimeModeling/Modeling/twri_objective.jl 71.42% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   82.91%   83.13%   +0.21%     
==========================================
  Files          28       34       +6     
  Lines        2459     2716     +257     
==========================================
+ Hits         2039     2258     +219     
- Misses        420      458      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mloubout mloubout force-pushed the geom-3d branch 12 times, most recently from b51564d to 921772c Compare February 18, 2024 02:50
@mloubout mloubout force-pushed the geom-3d branch 16 times, most recently from ded373a to 30a523f Compare March 23, 2024 01:59
@mloubout mloubout force-pushed the geom-3d branch 9 times, most recently from e9f7013 to 7e09cac Compare March 25, 2024 23:43
@mloubout mloubout merged commit 18119a3 into master Mar 27, 2024
45 checks passed
@mloubout mloubout deleted the geom-3d branch March 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataPreconditioner works strange Will DataPreconditioner work with OOC data in the future?
1 participant