Add custom exceptions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename to a .phtml extension.
This ensures that slimphp#49 is actually fixed.
No need to catch Throwable and Exception any more. Also import and document exceptions used.
This reduces cognitive load as there's no need to scan to see if a variable is used within the string.
Rather than use the root RuntimeException, use our own PhpTemplateNotFoundException so that it can be caught specifically.
akrabat
force-pushed
the
custom-exceptions
branch
from
99c569e
to
12ce65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use the root RuntimeException, use our own
PhpTemplateNotFoundExceptionso that it can be caught specifically.Fixes #43.
This PR is branched off of #55's branch, so should be rebased after #55 is merged.