New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/init command #22
Conversation
e71d57d
to
4c275ec
Compare
ce8df3e
to
3bb6dc8
Compare
ce8ab83
to
7954ca0
Compare
e92062f
to
1abaa02
Compare
47b62c6
to
4ead8c0
Compare
@ABGEO I won’t be able to review until the weekend. I have other engagements at the moment. |
# Conflicts: # composer.json
@ABGEO The init command doesn't seem to work for me. It asks me for composer information: package name, description, license. But then it doesn't ask me for the dependencies I want to install. The command I run is:
|
@l0gicgate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright @ABGEO just a few last things then I'm merging:
The following messages can we reformat them:
Do you want to configure the PSR-7 HTTP message interface?
"Would you like to choose a PSR-7 implentation?"
Do you want to configure Dependency Container? (yes/no)
"Would you like to configure a dependency injection container?"
Do you want to use PSR-3 Logger? (yes/no)
"Would you like to configure a logger?" -> Since there's only one option, yes defaults to installing MonoLog.
Done.
No, this is not possible in the Symfony console. |
Great work @ABGEO! Thank you for this contribution. Sorry for taking so long to merge this. |
Thanks @l0gicgate! It's a great pleasure to work with you. I'll try to help with other things too :) |
Resolves #3
I implemented the initialization command and profile structure. I decided to use a separate directory for each profile. So each Slim init profile must:
Slim\Console\Command\Initializer\Profiles\InitProfileInterface
or extendSlim\Console\Command\Initializer\Profiles\AbstractInitProfile
;run
method;This structure allows us to easily define new profiles and use them. We can also publish profiles on Packagist and require them using composer.
I implemented
Blank
profile with following features:composer.json
After the review I will write tests.