New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Key support and Key Array support to flash messages #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Key support for storing messages
- Updated for Change To addMessage
Updated Usage for change in function parameters
- Add Multiple message per key support
- Updated test cases to support multiple values for a key
geggleto
changed the title
Adding Key support to flash Messages
Adding Key support and Key Array support to flash messages
Apr 1, 2015
- Fixed Derp
- Update Test Cases
Should $key be a set of constants on the class (or a static array of key => key)?
And the class check that $key is valid before allowing it in (or retrieving it) ?
Just curious. |
I guess you could have constants, but I'm not sure we need them. Up to you though. |
I think it should be up to the app itself to maintain the set of constants. |
/cc @codeguy @gabriel403 fixed it all up |
codeguy
added a commit
that referenced
this pull request
Apr 14, 2015
Adding Key support and Key Array support to flash messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my apps, I find having different keys to store flash messages a critical component. Being able to flag [warn] or [error] messages for rendering in my UI is pretty critical. This PR attempts to add this functionality.