New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing string, returns it inside array #24
Comments
As this change came in as PR #1 and was merged by Josh, I think it's unlikely to change. |
I just ran into this, too. I'm curious why all flashed values are forced into an array when that's just one use case among many. |
If the $key already exists in the storage, create array with previously flashed message and the current one.
I have created new pull request that should resolve this. It returns array only if you add more than one message under the same key. |
slimphp#24 message in array
Hmm not sure if that would be expected behaviour. When using type hinting in PHP7.x it should always return the same type, in this case array. When expecting a single string #29 could be used. |
Hmm, @MrSam your solution may be better... Until it's available I will have a fork of this repository with my solution implemented and it will be published on Packagist as I needed it immediately in my project, so please don't consider my actions being rude. I might have only wrap this library but I wasn't thinking about it much and since there are others requesting this feature, this solution might get handy. |
Addresses slimphp#29, slimphp#24
Closed #33 |
@geggleto said he will fix what he broke 馃拑
5bd5f75#diff-8b1b6164c747942bdb2576f146cf4e5eR87
The text was updated successfully, but these errors were encountered: