Truncating response body #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests ETag and Last-Modified to ensure the response body shouldn't send data when their is a cache hit.
Replacing the response body on cache hits to reduce data transmission
JimTools
commented
Apr 23, 2024
| $this->type = $type; | ||
| $this->maxAge = $maxAge; | ||
| $this->mustRevalidate = $mustRevalidate; | ||
| $this->streamFactory = $streamFactory; |
There was a problem hiding this comment.
Maybe for now it's better to add slim/psr7 and call StreamFactory this would make it easier for anyone already using this package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truncating the body to reduce data transmission on cache hits.
closes #54