This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
ParseRequestBody: like ContentTypes, but without breaking getBody() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supplementing #2
This feature branch would contain the variant where ContentTypes is deprecated and replaced by ParseRequestBody.
This solution is not pretty, a programmer would need to write
$env = $app->environment();
$env['slim.input_parsed']
On the other hand, sneaking a method into the request object, so it would be possible to
$app->request->getBodyParsed()
would result in complex code more likely to contain bugs, and will sure enough cause some other programmer considerable headache sometime in the future.
That's why I left it that way.
In the end, it MAY be best to just do nothing and discard both of my pull requests. But first I wanted to discuss the matter with you.
regards,
Max