Merge pull request #87 from l0gicgate/AddExceptionsToUnusableNonBuffe…

…redBodyMethods Add exceptions to unusable NonBufferedBody methods
slimphp · May 3, 2019 · 01bb662 · 01bb662
2 parents 8ce2c78 + 77be549
commit 01bb662
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 3 deletions.
diff --git a/src/NonBufferedBody.php b/src/NonBufferedBody.php
@@ -10,6 +10,7 @@
 namespace Slim\Psr7;
 
 use Psr\Http\Message\StreamInterface;
+use RuntimeException;
 
 class NonBufferedBody implements StreamInterface
 {
@@ -26,6 +27,7 @@ public function __toString(): string
      */
     public function close(): void
     {
+        throw new RuntimeException('A NonBufferedBody is not closable.');
     }
 
     /**
@@ -73,13 +75,15 @@ public function isSeekable(): bool
      */
     public function seek($offset, $whence = SEEK_SET)
     {
+        throw new RuntimeException('A NonBufferedBody is not seekable.');
     }
 
     /**
      * {@inheritdoc}
      */
     public function rewind(): void
     {
+        throw new RuntimeException('A NonBufferedBody is not rewindable.');
     }
 
     /**
@@ -120,7 +124,7 @@ public function isReadable(): bool
      */
     public function read($length): string
     {
-        return '';
+        throw new RuntimeException('A NonBufferedBody is not readable.');
     }
 
     /**

diff --git a/tests/NonBufferedBodyTest.php b/tests/NonBufferedBodyTest.php
@@ -10,6 +10,7 @@
 namespace Slim\Tests\Psr7;
 
 use PHPUnit\Framework\TestCase;
+use RuntimeException;
 use Slim\Psr7\NonBufferedBody;
 use Slim\Psr7\Response;
 use Slim\Tests\Psr7\Assets\HeaderStack;
@@ -37,7 +38,6 @@ public function testTheStreamContract()
         self::assertFalse($body->isSeekable(), 'Cannot seek');
         self::assertTrue($body->isWritable(), 'Body is writable');
         self::assertFalse($body->isReadable(), 'Body is not readable');
-        self::assertSame('', $body->read(10), 'Data cannot be retrieved once written');
         self::assertSame('', $body->getContents(), 'Data cannot be retrieved once written');
         self::assertNull($body->getMetadata(), 'Metadata mechanism is not implemented');
     }
@@ -78,7 +78,6 @@ public function testWithAddedHeader()
         ], HeaderStack::stack());
     }
 
-
     public function testWithoutHeader()
     {
         (new Response())
@@ -88,4 +87,40 @@ public function testWithoutHeader()
 
         self::assertSame([], HeaderStack::stack());
     }
+
+    /**
+     * @expectedException RuntimeException
+     * @expectedExceptionMessage A NonBufferedBody is not closable.
+     */
+    public function testCloseThrowsRuntimeException()
+    {
+        (new NonBufferedBody())->close();
+    }
+
+    /**
+     * @expectedException RuntimeException
+     * @expectedExceptionMessage A NonBufferedBody is not seekable.
+     */
+    public function testSeekThrowsRuntimeException()
+    {
+        (new NonBufferedBody())->seek(10);
+    }
+
+    /**
+     * @expectedException RuntimeException
+     * @expectedExceptionMessage A NonBufferedBody is not rewindable.
+     */
+    public function testRewindThrowsRuntimeException()
+    {
+        (new NonBufferedBody())->rewind();
+    }
+
+    /**
+     * @expectedException RuntimeException
+     * @expectedExceptionMessage A NonBufferedBody is not readable.
+     */
+    public function testReadThrowsRuntimeException()
+    {
+        (new NonBufferedBody())->read(10);
+    }
 }