Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant checks #104

Merged
merged 1 commit into from Jul 20, 2019
Merged

Remove redundant checks #104

merged 1 commit into from Jul 20, 2019

Conversation

mapogolions
Copy link
Contributor

Redundant sequential checks spawn unreachable code. The method call createStreamFromFile checks the argument three times : is_resource -> is_resource -> is_resource

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.733% when pulling eff0cde on mapogolions:redundant_sequencial_checks into b5e2940 on slimphp:master.

@l0gicgate
Copy link
Member

@adriansuter I'm okay with this. Please approve as well before I merge.

@l0gicgate l0gicgate added this to the 0.4 milestone Jul 19, 2019
@adriansuter
Copy link
Contributor

Good to merge.

@l0gicgate l0gicgate merged commit 573678c into slimphp:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mapogolions @coveralls @l0gicgate @adriansuter