Allow phpunit v4.8 and above for compatibility with PHP 5.5. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -18,7 +18,7 @@ | |||
| "monolog/monolog": "^1.17" | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^5.4" | |||
| "phpunit/phpunit": ">=4.8 < 6.0" | |||
There was a problem hiding this comment.
To prevent potential backwards compatibility breaks that might arise from a major update.
|
3.1.1 released with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the compatibility issue mentioned by @oanhnn in #35
Composer was set to require phpunit 5.4 and above, but phpunit 5.4 only supports PHP 5.6+, but Slim 3 support PHP 5.5. The test examples are compatible with phpunit v4, so I have altered
composer.jsonto use the maximum possible version between 4.8 and 6.