Bug-fix for router

slimphp · Oct 4, 2016 · a38edd9 · a38edd9
1 parent 7c33189
commit a38edd9
Show file tree

Hide file tree

Showing 3 changed files with 77 additions and 2 deletions.
diff --git a/Slim/DefaultServicesProvider.php b/Slim/DefaultServicesProvider.php
@@ -91,8 +91,14 @@ public function register($container)
                 if (isset($container->get('settings')['routerCacheFile'])) {
                     $routerCacheFile = $container->get('settings')['routerCacheFile'];
                 }
+
 
-                return (new Router)->setCacheFile($routerCacheFile);
+                $router = (new Router)->setCacheFile($routerCacheFile);
+                if (method_exists($router, 'setContainer')) {
+                    $router->setContainer($container);
+                }
+
+                return $router;
             };
         }
 

diff --git a/Slim/Router.php b/Slim/Router.php
@@ -9,6 +9,7 @@
 namespace Slim;
 
 use FastRoute\Dispatcher;
+use Interop\Container\ContainerInterface;
 use InvalidArgumentException;
 use RuntimeException;
 use Psr\Http\Message\ServerRequestInterface;
@@ -29,6 +30,13 @@
  */
 class Router implements RouterInterface
 {
+    /**
+     * Container Interface
+     *
+     * @var ContainerInterface
+     */
+    protected $container;
+
     /**
      * Parser
      *
@@ -126,6 +134,24 @@ public function setCacheFile($cacheFile)
         return $this;
     }
 
+    /**
+     * @param ContainerInterface $container
+     */
+    public function setContainer(ContainerInterface $container)
+    {
+        $this->container = $container;
+    }
+
+    /**
+     * @return ContainerInterface
+     */
+    public function getContainer()
+    {
+        return $this->container;
+    }
+
+
+
     /**
      * Add route
      *
@@ -189,7 +215,12 @@ public function dispatch(ServerRequestInterface $request)
      */
     protected function createRoute($methods, $pattern, $callable)
     {
-        return new Route($methods, $pattern, $callable, $this->routeGroups, $this->routeCounter);
+        $route = new Route($methods, $pattern, $callable, $this->routeGroups, $this->routeCounter);
+        if (!empty($this->container)) {
+            $route->setContainer($this->container);
+        }
+
+        return $route;
     }
 
     /**

diff --git a/tests/AppTest.php b/tests/AppTest.php
@@ -9,6 +9,7 @@
 
 namespace Slim\Tests;
 
+use Interop\Container\ContainerInterface;
 use Slim\App;
 use Slim\Container;
 use Slim\Exception\MethodNotAllowedException;
@@ -22,6 +23,7 @@
 use Slim\Http\RequestBody;
 use Slim\Http\Response;
 use Slim\Http\Uri;
+use Slim\Router;
 use Slim\Tests\Mocks\MockAction;
 
 class AppTest extends \PHPUnit_Framework_TestCase
@@ -1938,4 +1940,40 @@ public function testForUnexpectedDataInOutputBuffer()
         $container['settings']['addContentLengthHeader'] = true;
         $response = $method->invoke($app, $response);
     }
+
+
+    public function testContainerSetToRoute()
+    {
+        // Prepare request and response objects
+        $env = Environment::mock([
+            'SCRIPT_NAME' => '/index.php',
+            'REQUEST_URI' => '/foo',
+            'REQUEST_METHOD' => 'GET',
+        ]);
+        $uri = Uri::createFromEnvironment($env);
+        $headers = Headers::createFromEnvironment($env);
+        $cookies = [];
+        $serverParams = $env->all();
+        $body = new RequestBody();
+        $req = new Request('GET', $uri, $headers, $cookies, $serverParams, $body);
+        $res = new Response();
+
+        $mock = new MockAction();
+
+        $app = new App();
+        $container = $app->getContainer();
+        $container['foo'] = function () use ($mock, $res) {
+            return $mock;
+        };
+
+        /** @var $router Router */
+        $router = $container['router'];
+        $router->map(['get'], '/foo', 'foo:bar');
+
+        // Invoke app
+        $resOut = $app($req, $res);
+
+        $this->assertInstanceOf('\Psr\Http\Message\ResponseInterface', $resOut);
+        $this->assertEquals(json_encode(['name'=>'bar', 'arguments' => []]), (string)$res->getBody());
+    }
 }