$request->getBody() returns empty stream

[deadacute]

When I use $request->getParsedBody() everything works fine, but when I use $request->getBody() it returns just empty stream. According to geggleto it looks like the stream gets detached at some point.

demo: source, output

[JoeBengalen]

Maybe something with the pointer already being at the end after parsing the body?

[deadacute]

_rewind()_ing didn't help so I don't think that's the problem

[geggleto]

https://github.com/slimphp/Slim/blob/3.x/Slim/Http/Stream.php#L181

shows that the contents of the stream are returned, thus theres nothing left in the string.
slim uses getParsedBody internally which is why if its a parsable item the body is left empty.
Rewinding does not help because PHP is dumping the content as it reads it as its basically a byte buffer.

Only in a file implementation could you rewind since the data is on disk and not in memory.

I do believe this to be a bug in our implementation.

Upon Request class initialization the stream should be read in full and stored in a protected attribute, then it can be returned at will via __toString and getContents()

[deadacute]

As @geggleto mentioned according to php.net php://input can be read only once, because right now there is no support for a seek operation. I think there is a really simple solution of just dumping the whole body into a string and then creating a stream from it. Not really a clean solution, but I can't seem to find a better one.

[geggleto]

For reference: https://github.com/phly/http/blob/master/src/PhpInputStream.php#L38

[geggleto]

//cc @akrabat

[akrabat]

@Outfl3sh The tip of the 3.x branch should fix this issue for you.

[deadacute]

Great, thanks for the fix.