Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slim3] Do not assume response body stream is seekable #1434

Closed
codeguy opened this issue Aug 12, 2015 · 1 comment
Closed

[Slim3] Do not assume response body stream is seekable #1434

codeguy opened this issue Aug 12, 2015 · 1 comment
Assignees
@codeguy
Labels
bug
Milestone
3.0.0 RC1

Comments

@codeguy
Copy link
Member

codeguy commented Aug 12, 2015

Not all streams are seekable, and we should not assume this here:

https://github.com/slimphp/Slim/blob/3.x/Slim/App.php#L352

This bit me when trying to send a Guzzle PumpStream which tosses an exception when you try to seek it. I'll send a PR shortly.
@codeguy codeguy added the bug label Aug 12, 2015
@codeguy codeguy added this to the 3.0.0 RC1 milestone Aug 12, 2015
@codeguy codeguy self-assigned this Aug 12, 2015
@geggleto
Copy link
Member

I am pretty sure this came about from the discussion about php://input not being seekable

silentworks added a commit that referenced this issue Aug 12, 2015
@silentworks
Merge pull request #1435 from codeguy/3.x-verify-body-streamable
15aea44 
Do not assume response body is seekable in App::respond. Fixes #1434
@akrabat akrabat closed this as completed Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeguy codeguy

Labels
bug
Projects
None yet
Milestone
3.0.0 RC1
Development

No branches or pull requests
3 participants
@codeguy @akrabat @geggleto