Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume Response is writable #1530

Closed
codeguy opened this issue Oct 7, 2015 · 2 comments
Closed

Do not assume Response is writable #1530

codeguy opened this issue Oct 7, 2015 · 2 comments
Labels
bug
Milestone
3.0.0 RC2

Comments

@codeguy
Copy link
Member

codeguy commented Oct 7, 2015

In Route.php line 340, we should not assume Response body is writable.

https://github.com/slimphp/Slim/blob/3.x/Slim/Route.php#L340
@codeguy codeguy added the bug label Oct 7, 2015
@codeguy codeguy added this to the 3.0.0 RC2 milestone Oct 7, 2015
@codeguy
Copy link
Member Author

codeguy commented Oct 7, 2015

Also line 336

@gabriel403
Copy link
Contributor

@codeguy I'm happy to have a go at this, but what should we do if it's not writeable?

@gabriel403 gabriel403 mentioned this issue Oct 7, 2015
Merged
@akrabat akrabat mentioned this issue Oct 8, 2015
Merged
@akrabat akrabat closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0.0 RC2
Development

No branches or pull requests
3 participants
@codeguy @akrabat @gabriel403