Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #1321

Merged
merged 2 commits into from Jun 28, 2015
Merged

Minor improvements #1321

merged 2 commits into from Jun 28, 2015

Conversation

theodorejb
Copy link
Contributor

  • Fixed Stream exception message grammar
  • Minor optimizations:
    • Avoid retrieving container settings in a loop
    • If $newResponse is a ResponseInterface, it isn't necessary to also check if it is a string

@theodorejb
Fix Stream exception message grammar
a9cea3e
@theodorejb
Minor optimizations:
8e4caf6 
1. Avoid retrieving container settings in a loop
2. If $newResponse is a ResponseInterface, it isn't necessary to also check if it is a string
@akrabat akrabat merged commit 8e4caf6 into slimphp:develop Jun 28, 2015
@akrabat
Copy link
Member

akrabat commented Jun 28, 2015

Thanks.

@theodorejb theodorejb deleted the minor-improvements branch June 28, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theodorejb @akrabat