Exclude files and folder from dist #1676
Conversation
Signed-off-by: Fery Wardiyanto <ferywardiyanto@gmail.com>
| @@ -0,0 +1,12 @@ | |||
| # Enforce Unix newlines | |||
| * text=lf | |||
There was a problem hiding this comment.
Do we want this @codeguy? You're the resident Windows developer, so may have an opinion?
There was a problem hiding this comment.
Will look at this later today.
On Tue, Dec 15, 2015 at 3:28 AM Rob Allen notifications@github.com wrote:
In .gitattributes
#1676 (comment):@@ -0,0 +1,12 @@
+# Enforce Unix newlines
+* text=lfDo we want this @codeguy https://github.com/codeguy? You're the
resident Windows developer, so may have an opinion?—
Reply to this email directly or view it on GitHub
https://github.com/slimphp/Slim/pull/1676/files#r47608456.
There was a problem hiding this comment.
Unix newlines are in PSR-2 standard which Slim says it follows. Everybody should use the same newlines. Otherwise diff will be borken.
There was a problem hiding this comment.
What @tuupola said. PSR-2 requires Unix LF line returns. So I give this a big 👍
There was a problem hiding this comment.
Git translates line returns on pull and commit. So it's not really a big deal, right?
…-dist Exclude files and folder from dist
|
Thanks for merging. Anyway, may I ask. Are you guys has plan to implement it for another repo under slimphp org? |
|
@feryardiant if you see any other repo that would benefit from this, send a PR. |
|
Got it 👍 |
Described here https://redd.it/2jzp6k