Write to the error log if displayErrorDetails is false #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displayErrorDetails is false, then the developer doesn't get any information on the exception. Add this information to the error log so that they can find it.
|
ping @silentworks, @codeguy |
| */ | ||
| protected function renderTextException(Exception $exception) | ||
| { | ||
| $html = sprintf('Type: %s' . PHP_EOL, get_class($exception)); |
There was a problem hiding this comment.
Nit: Why is this variable named $html instead of $text? The docblock saysRender exception as Text.
|
@campersau Updated. Thank you! |
|
@akrabat thoughts on just including monolog? |
|
Don't want to. It's not the only PSR-3 logging library |
|
Looks good to me. |
|
/me waits for @silentworks to merge it… |
silentworks
added a commit
that referenced
this pull request
Feb 13, 2016
Write to the error log if displayErrorDetails is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displayErrorDetails is false, then the developer doesn't get any information on the exception. Add this information to the error log so that they can find it.
Closes #1761