New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to the error log if displayErrorDetails is false #1764

Merged
merged 2 commits into from Feb 13, 2016

Conversation

Projects
None yet
4 participants
@akrabat
Member

akrabat commented Feb 11, 2016

When displayErrorDetails is false, then the developer doesn't get any information on the exception. Add this information to the error log so that they can find it.

Closes #1761

Write to the error log if displayErrorDetails is false
When displayErrorDetails is false, then the developer doesn't get any
information on the exception. Add this information to the error log so
that they can find it.

@akrabat akrabat added this to the 3.2.0 milestone Feb 11, 2016

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat
Member

akrabat commented Feb 11, 2016

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 11, 2016

Member

@campersau Updated. Thank you!

Member

akrabat commented Feb 11, 2016

@campersau Updated. Thank you!

@geggleto

This comment has been minimized.

Show comment
Hide comment
@geggleto

geggleto Feb 11, 2016

Contributor

@akrabat thoughts on just including monolog?

Contributor

geggleto commented Feb 11, 2016

@akrabat thoughts on just including monolog?

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 11, 2016

Member

Don't want to. It's not the only PSR-3 logging library

Member

akrabat commented Feb 11, 2016

Don't want to. It's not the only PSR-3 logging library

@silentworks

This comment has been minimized.

Show comment
Hide comment
@silentworks

silentworks Feb 11, 2016

Member

Looks good to me.

Member

silentworks commented Feb 11, 2016

Looks good to me.

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat Feb 11, 2016

Member

/me waits for @silentworks to merge it…

Member

akrabat commented Feb 11, 2016

/me waits for @silentworks to merge it…

silentworks added a commit that referenced this pull request Feb 13, 2016

Merge pull request #1764 from akrabat/error_log
Write to the error log if displayErrorDetails is false

@silentworks silentworks merged commit 678b7f1 into slimphp:3.x Feb 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akrabat akrabat added the improvement label Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment