Added failing unit test for bad HTTP requests.

[nickdnk]

Hello

As requested I have written a failing unit test to illustrate the issue with an unsupported method used by clients.

Currently this results in a code 500 error on an "out-of-the-box" Slim deployment, which is not ideal.

Issue: #2005

[coveralls]

Coverage remained the same at 97.199% when pulling 2b6812d on nickdnk:3.x into 2f29cc2 on slimphp:3.x.

[dopesong]

FILE: /home/travis/build/slimphp/Slim/tests/AppTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 1985 | WARNING | [ ] Line exceeds 120 characters; contains 134
      |         |     characters
 1986 | WARNING | [ ] Line exceeds 120 characters; contains 121
      |         |     characters
 1988 | ERROR   | [x] Opening brace should be on a new line
 2006 | ERROR   | [x] Function closing brace must go on the next line
      |         |     following the body; found 1 blank lines before
      |         |     brace

[akrabat]

@nickdnk Can you address the PHPCS issues please?

[nickdnk]

I'm sorry, but what does that mean? Ian told me to write this test to draw his attention to fixing it. He has an issue open for it, as do I.

Testing is not my strong suit.

Sent from my iPhone

On 18 Nov 2016, at 09.14, Rob Allen <notifications@github.commailto:notifications@github.com> wrote:

@nickdnkhttps://github.com/nickdnk Can you address the PHPCS issues please?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2031#issuecomment-261473206, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIBYsmfnHUy80tPZW2G1sG-XrI18B9KEks5q_V5QgaJpZM4Ko0lq.

[akrabat]

@nickdnk If you look in CI section on here, you'll see: "Some checks were not successful".

Opening up, you see that this PR failed the Travis checks. Clicking on "Details" takes you to https://travis-ci.org/slimphp/Slim/builds/173057833.

Pick the 5.6 one, click into it and scroll to the bottom and you'll see what @dopesong posted earlier. This is the list of errors created by phpcs.

Specifically in AppTest.php, there are problems with lines 1988 and 2006.

[nickdnk]

Aha okay. I'll have a look at that when I can.

This means the actual code is fine but it has to do with new lines, indents and so on, correct?

Sent from my iPhone

On 18 Nov 2016, at 11.48, Rob Allen <notifications@github.commailto:notifications@github.com> wrote:

@nickdnkhttps://github.com/nickdnk If you look in CI section on here, you'll see: "Some checks were not successful".

Opening up, you see that this PR failed the Travis checks. Clicking on "Details" takes you to https://travis-ci.org/slimphp/Slim/builds/173057833.

Pick the 5.6 one, click into it and scroll to the bottom and you'll see what @dopesonghttps://github.com/dopesong posted earlier. This is the list of errors created by phpcs.

Specifically in AppTest.php, there are problems with lines 1988 and 2006.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2031#issuecomment-261503084, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIBYsnP1B_PJTQ8_NmNZI1Gs2UeD_468ks5q_YJjgaJpZM4Ko0lq.

[nickdnk]

Aha okay. I'll have a look at that when I can.

This means the actual code is fine but it has to do with new lines, indents and so on, correct?

Sent from my iPhone

On 18 Nov 2016, at 11.48, Rob Allen <notifications@github.commailto:notifications@github.com> wrote:

@nickdnkhttps://github.com/nickdnk If you look in CI section on here, you'll see: "Some checks were not successful".

Opening up, you see that this PR failed the Travis checks. Clicking on "Details" takes you to https://travis-ci.org/slimphp/Slim/builds/173057833.

Pick the 5.6 one, click into it and scroll to the bottom and you'll see what @dopesonghttps://github.com/dopesong posted earlier. This is the list of errors created by phpcs.

Specifically in AppTest.php, there are problems with lines 1988 and 2006.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2031#issuecomment-261503084, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIBYsnP1B_PJTQ8_NmNZI1Gs2UeD_468ks5q_YJjgaJpZM4Ko0lq.

[akrabat]

Correct - the PHPCS checks are about the way the code is laid out.

[coveralls]

Coverage increased (+0.06%) to 97.256% when pulling c65dbad on nickdnk:3.x into 2f29cc2 on slimphp:3.x.

[nickdnk]

I think it's good now, yes?

[akrabat]

The test is correctly failing, yes :)

[akrabat]

Now we just need @iansltx or someone else to fix it :)

[akrabat]

Can you add the annotation to tell PHPUnit to skip this test?

I can then merge it and when @iansltx (or whoever) branches to fix it, they can remove it on their branch.

[coveralls]

Coverage increased (+0.06%) to 97.258% when pulling 265ddc0 on nickdnk:3.x into 2f29cc2 on slimphp:3.x.

[nickdnk]

Done

[akrabat]

Thanks - the CI passes now :)

[akrabat]

Fixed as part of #2141