Changing PHP_EOL to "\r\n" #2142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP standard specifies that CR LF ("\r\n") should be used for separating elements in an HTTP request/response.
https://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.2
Using PHP_EOL could potentially break some applications.
|
Looks good, but you also need to fix the tests |
|
Yeah, the tests passed on my Windows system where PHP_EOL is "\r\n"! I've fixed the tests, so I guess I create a new pull request and close this one? |
|
Just push to your branch and this PR will update |
|
When I first made changes, I made them on my fork's master branch instead of the branch that I created specifically for this pull request. (I'm new to contributing to others' repos.) I think it'll be easier if I just create a pull request for the correct branch. |
|
okay. You may find https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ helpful. |
|
Thanks for the help! I'll check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP standard specifies that CR LF ("\r\n") should be used for separating elements in an HTTP request/response.
https://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.2
Using PHP_EOL could potentially break some applications as PHP_EOL is not guaranteed to be "\r\n".