Set status to 302 if Location header set

[akrabat]

If the Location header is set, then set to the status code to 302 if
it is 200. This ensures that code like this still works:

return $response->withHeader('Location', '/login');

However if the status code is set to something other than 200, when we
assume intent by the user, so do not override their code. e.g. this
code works does not change the status code from 201:

return $response->withStatus(201)->withHeader('Location', '/item/1');

Closes #2344

[coveralls]

Coverage decreased (-0.04%) to 93.24% when pulling c96a4c6 on akrabat:fix-redirect-with-200 into f6884a7 on slimphp:3.x.

[nickdnk]

May I suggest using === for comparison:

if (200 === $clone->getStatusCode() && 'location' === strtolower($name)) {
    $clone = $clone->withStatus(302);
}

[akrabat]

May I suggest using === for comparison:

Done.

[coveralls]

Coverage decreased (-0.04%) to 93.24% when pulling afef7ad on akrabat:fix-redirect-with-200 into f6884a7 on slimphp:3.x.

[coveralls]

Coverage decreased (-0.04%) to 93.24% when pulling afef7ad on akrabat:fix-redirect-with-200 into f6884a7 on slimphp:3.x.

[silentworks]

Please don't Yoda the codebase. Lets keep it consistent with everywhere else in the codebase.

[akrabat]

Done. We should put in a phpcs sniff to prevent it!

[coveralls]

Coverage decreased (-0.04%) to 93.24% when pulling 0b40294 on akrabat:fix-redirect-with-200 into f6884a7 on slimphp:3.x.