Use rawurldecode instead of urldecode for route argument #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slimphp Hi, can I have any feedback on my PR? Travis is failing on php7.1 without any reason. |
|
Duplicate + BC break for Slim 3: #2000 |
|
@danopz Oh! I didn't find the duplication, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urldecode is used in order to decode part of the route arguments but according to the php documentation:
According to the RFC-1866, the '+' to space conversion is only valid after the '?' part of the url: https://stackoverflow.com/a/40292260/4234729