Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PSR-15 RequestHandlers to be used as route callables #2497

Merged
merged 2 commits into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@akrabat
Copy link
Member

commented Sep 10, 2018

This requires modifying CallableResolver to change the method to handle if the callable object is a RequestHandlerInterface.

Also, we introduce a RequestHandler invocation strategy that is automatically applied by the Route is a RequestHandlerInterface callable is invoked.

Fixes #2488.
Fixes #2052.

akrabat added some commits Sep 6, 2018

Allow PSR-15 RequestHandlers to be used as route callables
This requires modifying `CallableResolver` to change the method to
`handle` if the callable object is a RequestHandlerInterface. Also,
we introduce a `RequestHandler` invocation strategy that is
automatically applied by the `Route` is a RequestHandlerInterface
callable is invoked.

@akrabat akrabat requested review from silentworks and designermonkey Sep 10, 2018

@coveralls

This comment has been minimized.

Copy link

commented Sep 10, 2018

Coverage Status

Coverage increased (+0.2%) to 97.966% when pulling 2bd6de1 on akrabat:psr-15-request-handler2 into 7c1a672 on slimphp:4.x.

@akrabat

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2018

Travis build result appears to be missing. It's here: https://travis-ci.org/slimphp/Slim/builds/426856659

@akrabat akrabat added this to the 4.0 milestone Sep 16, 2018

@akrabat akrabat added the Slim 4 label Sep 16, 2018

akrabat added a commit to akrabat/Slim that referenced this pull request Nov 18, 2018

@akrabat akrabat merged commit 2bd6de1 into slimphp:4.x Nov 18, 2018

1 check passed

coverage/coveralls Coverage increased (+0.2%) to 97.966%
Details

@akrabat akrabat deleted the akrabat:psr-15-request-handler2 branch Apr 18, 2019

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.