Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Remove pathFor() and rename relativePathFor() with relativeUrlFor() #2654

Merged
merged 3 commits into from Apr 24, 2019

Conversation

Projects
None yet
2 participants
@l0gicgate
Copy link
Contributor

commented Apr 24, 2019

As per the discussion in #2493 and the stack overflow post explaining relative/absolute

relativePathFor() and pathFor() are getting entirely removed from the RouteParser component. Since this is a new interface that is the result of the fragmentation of the now deprecated Router component the user will need to re-learn the new interface so no point in implementing a warning of deprecation.

The RouteParser will now have this interface:

  • RouteParser::fullUrlFor() - Absolute URL
  • RouteParser::urlFor() - Root Relative URL formerly pathFor()
  • RouteParser::relativeUrlFor() - Relative URL formerly relativePathFor()

@l0gicgate l0gicgate added the Slim 4 label Apr 24, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Apr 24, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 24, 2019

Coverage Status

Coverage decreased (-0.002%) to 99.325% when pulling eb6a182 on l0gicgate:4.x-RefactorRouteParser into 65dd548 on slimphp:4.x.

@l0gicgate l0gicgate merged commit e3a9c35 into slimphp:4.x Apr 24, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 99.325%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RefactorRouteParser branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.