Static closures resolving #3067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisDN
changed the title
ElisDN
force-pushed
the
static-closure
branch
2 times, most recently
from
f46298d
to
cc67e40
Compare
ElisDN
force-pushed
the
static-closure
branch
4 times, most recently
from
0221dc4
to
6dc3f36
Compare
l0gicgate
reviewed
Mar 29, 2021
| /** @var Closure $callable */ | ||
| $callable = $callable->bindTo($this->container); | ||
| /** @var Closure $bound */ | ||
| $bound = @$callable->bindTo($this->container); |
There was a problem hiding this comment.
We don't suppress errors in this codebase. This isn't a fix.
There was a problem hiding this comment.
I know. But there is no legal way to check that Closure is static.
There was a problem hiding this comment.
Until there is a way to do this without suppressing errors, it will not be merged unfortunately. There is no upside to allowing static closures. This is a micro optimization.
|
See #3067 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636 PHP Warning, wich still actual in all PHP versions.