Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan 0.12 errors #177

Merged
merged 2 commits into from May 6, 2020
Merged

Fix phpstan 0.12 errors #177

merged 2 commits into from May 6, 2020

Conversation

adriansuter
Copy link
Contributor

@adriansuter adriansuter commented May 6, 2020 •
edited

This PR fixes #175

I could not fix

------ --------------------------------------------------------------------------------------------------------------------------------------------
  Line   Twig.php                                                                                                                                   
 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  35     Class Slim\Views\Twig implements generic interface ArrayAccess but does not specify its types: TKey, TValue
          You can turn this off by setting checkGenericClassInNonGenericObjectType: false in your Twig-View\phpstan.neon.dist.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------

other than by adding the setting.

dependabot-preview bot and others added 2 commits May 6, 2020 16:52
@dependabot-preview
Update phpstan/phpstan requirement from ^0.11.15 to ^0.11.15 || ^0.12.0
9085488 
Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Commits](phpstan/phpstan@0.11.15...0.12.23)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@adriansuter
Fix phpstan update errors
f1ceac3
@l0gicgate l0gicgate added this to the 3.2.0 milestone May 6, 2020
@l0gicgate l0gicgate merged commit 94bcc75 into slimphp:3.x May 6, 2020
@adriansuter adriansuter deleted the patch-phpstan-update branch May 6, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adriansuter @l0gicgate