Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace isinstance with separate except block #1

Merged

Conversation

mercutiodesign
Copy link
Contributor

Instead of testing if an exception is a HTTPException with isinstance, I would propose to just add a dedicated except block for this

@slingamn
Copy link
Owner

Thanks for the PR! I had it like this before and it produced a Pylint W0706. However, it's not important anymore that the project pass Pylint (I envision anyone vendoring it will have Pylint ignore the entire file), so I'll reconsider this.

@slingamn slingamn merged commit ec701e4 into slingamn:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants