Skip to content

Commit

Permalink
Incorporate feedback from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
hunger committed Jun 27, 2023
1 parent f7542c2 commit 116ef23
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .clippy.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
# Copyright © SixtyFPS GmbH <info@slint.dev>
# SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.0 OR LicenseRef-Slint-commercial

type-complexity-threshold = 2500
too-many-arguments-threshold = 10
2 changes: 1 addition & 1 deletion .reuse/dep5
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Files: */slint-logo-*.svg */slint-logo-*.png */Slint_icon_*.svg */Slint_icon_*.p
Copyright: Copyright © SixtyFPS GmbH <info@slint.dev>
License: CC-BY-ND-4.0

Files: .gitattributes .gitignore */.gitignore .dockerignore .prettierignore .pre-commit-config.yaml .vscode/* cspell.json rustfmt.toml .mailmap */.eslintrc.yml Cargo.lock .clippy.toml
Files: .gitattributes .gitignore */.gitignore .dockerignore .prettierignore .pre-commit-config.yaml .vscode/* cspell.json rustfmt.toml .mailmap */.eslintrc.yml Cargo.lock
Copyright: Copyright © SixtyFPS GmbH <info@slint.dev>
License: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.0 OR LicenseRef-Slint-commercial

Expand Down
1 change: 0 additions & 1 deletion examples/virtual_keyboard/rust/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ mod virtual_keyboard {
pub fn init(app: &MainWindow) {
let weak = app.as_weak();
app.global::<VirtualKeyboardHandler>().on_key_pressed({
let weak = weak;
move |key| {
weak.unwrap()
.window()
Expand Down
2 changes: 2 additions & 0 deletions internal/interpreter/highlight.rs
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@ fn find_element_at_offset(component: &Rc<Component>, path: PathBuf, offset: u32)
fn repeater_path(elem: &ElementRc) -> Option<Vec<String>> {
let enclosing = elem.borrow().enclosing_component.upgrade().unwrap();
if let Some(parent) = enclosing.parent_element.upgrade() {
// This is not a repeater, it might be a popup menu which is not supported ATM
parent.borrow().repeated.as_ref()?;

let mut r = repeater_path(&parent)?;
r.push(parent.borrow().id.clone());
Some(r)
Expand Down

0 comments on commit 116ef23

Please sign in to comment.