Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the window parameter from SoftwareRenderer's render functions #1545

Closed
tronical opened this issue Aug 26, 2022 · 0 comments · Fixed by #1549
Closed

Remove the window parameter from SoftwareRenderer's render functions #1545

tronical opened this issue Aug 26, 2022 · 0 comments · Fixed by #1549
Assignees
@ogoffart
Milestone
0.3.0

Comments

@tronical
Copy link
Member

In the API review we decided that we can simplify the API of these two functions and make the more robust by

  • Letting the SoftwareRenderer's new() function take a &Weak<dyn WindowAdapter> and clone it internally.
  • Remove the window parameter from the render functions.
@tronical tronical added this to the 0.2.7 milestone Aug 26, 2022
ogoffart added a commit that referenced this issue Aug 29, 2022
@ogoffart
Sofware renderer: keep a Weak of the Window
1ddd20e 
Closes #1545

Not that `SoftwareRenderer::new()`  takes the Weak by value instead of
by reference, because coercing a reference to a `Weak` to a `&Weak<dyn>`
is not possible, while converting a Weak to a `Weak<dyn>` just works.
@ogoffart ogoffart mentioned this issue Aug 29, 2022
Merged
ogoffart added a commit that referenced this issue Aug 29, 2022
@ogoffart
Sofware renderer: keep a Weak of the Window
4f0e260 
Closes #1545

Not that `SoftwareRenderer::new()`  takes the Weak by value instead of
by reference, because coercing a reference to a `Weak` to a `&Weak<dyn>`
is not possible, while converting a Weak to a `Weak<dyn>` just works.
@tronical tronical modified the milestones: 0.2.7, 0.3.0 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogoffart ogoffart

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Sofware renderer: keep a Weak of the Window slint-ui/slint
2 participants
@tronical @ogoffart