Slint lsp allows to remove items referenced elsewhere #4872
Labels
Comments
ogoffart
added
bug
|
This ends up removing a named Element that is referenced elsewhere in the code. That's why it starts to fail compiling. I am not sure what I can do about that at this time. Remove the referencing code as well? It should obviously not continue to delete things after it error-ed out. |
I don't think that's a good idea to remove the referencing code. I think we should just not allow deleting them, and maybe showing a notification popup why we can't delete it. (It should be easy to detect if the id is used. Similar to the code that renames ids.) |
hunger
added a commit
to hunger/slint
that referenced
this issue
Mar 18, 2024
Only process key events while the preview is in design mode and does not show an error. So far the only key that actually does something is the delete key, which deletes elements. Unfortunately we do not know which text range is covered by the element we want to delete, so we delete random chunks of text. So disable that when we ran into an error. This partially addresses slint-ui#4872.
hunger
added a commit
to hunger/slint
that referenced
this issue
Mar 18, 2024
Only process key events while the preview is in design mode and does not show an error. So far the only key that actually does something is the delete key, which deletes elements. Unfortunately we do not know which text range is covered by the element we want to delete, so we delete random chunks of text. So disable that when we ran into an error. This partially addresses slint-ui#4872.
Merged
hunger
added a commit
that referenced
this issue
Mar 18, 2024
Only process key events while the preview is in design mode and does not show an error. So far the only key that actually does something is the delete key, which deletes elements. Unfortunately we do not know which text range is covered by the element we want to delete, so we delete random chunks of text. So disable that when we ran into an error. This partially addresses #4872.
|
The part where you can cause more deletions while the compilation has failed is fixed. The part where you can delete elements that are used elsewhere is still open. |
hunger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Slint nightly LSP plugin 17.03.2024
simplescreenrecorder-2024-03-17_12.08.02.mp4
UI files - https://github.com/qarmin/czkawka/tree/7.0.0/krokiet/ui
The text was updated successfully, but these errors were encountered: