vscode web extension #1300
Merged
vscode web extension #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor the LSP to be possible to compile for wasm.
When using wasm we can't use the lsp-server crate because that one use the
stdin/stdout to communicate.
Instead, we need will do the communication in TypeScript using the vscode
language server protocol library, and serialize the types to wasm. Fortunately
that's easy because the lsp-types crate contains all the serialized types.
This also "duplicate" the extension as a web extension that do not use process
to start the LSP, but use a web worker. Some of the extension code could
be refactored to avoid some duplication (like the status bar handling and such).
And add a "browser" entry point in the package.json
Finally, add a browserServerMain.ts entry point for our worker, it will try to load
the wasm code.
Currently this doesn't wirk: the browserServerMain.ts can't load the wasm.
Also todo is to write the code so that the wasm code can send the response and
notifications.
To debug, I type these commands in editor/vscode directory
npm run compile-web
code --extensionDevelopmentKind=web --extensionDevelopmentPath=$PWD ../..
* Use wasm-pack's web mode to create a .wasm file and an ESM module for the glue code * Import the .wasm file directly in browserServerMain.ts * And process it all with esbuild, which succeeds in seeing the .wasm import in browserServerMain.ts and then bundles it inline.
we need to use commonjs for the extension If we start the client before the server has loaded the wasm, we don't listen yet to the init message, so make sure not to start the client before we sent the "OK" message back. But it's still not working, the wasm code is called, but the parameter are not properly passed
Now it calls in the wasm properly. But i get borrowmut error because the wasm re-enter from send_notification into the request
tronical
approved these changes
May 31, 2022
Comment on lines
+31
to
+33
| if (m.data === "OK") { | ||
|
|
||
| client = new LanguageClient('slint-lsp', 'Slint LSP', clientOptions, worker); |
There was a problem hiding this comment.
Ahh, I guess the LanguageClient will overwrite worker.onmessage?
| #[wasm_bindgen] | ||
| pub fn handle_request( | ||
| &self, | ||
| _id: JsValue, |
There was a problem hiding this comment.
What is the role of the id? Should it be used or can it be omitted?
There was a problem hiding this comment.
The id is indeed the token that can be used if we want to cancel the request in the future.
but this is not used right now.
| }); | ||
|
|
||
| connection.onRequest((method, params, token) => { | ||
| return the_lsp.handle_request(token, method, params); |
There was a problem hiding this comment.
Ah, here the token becomes the id. Should it be used?
tronical
reviewed
May 31, 2022
| @@ -88,6 +89,7 @@ | |||
| "scripts": { | |||
| "vscode:prepublish": "npm run compile", | |||
There was a problem hiding this comment.
Maybe this helps with the CI:
Suggested change
| "vscode:prepublish": "npm run compile", | |
| "vscode:prepublish": "npm run compile && npm run compile-web", |
Build regular and web extension in one go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-servercrate to communicate because that uses stdin/stdout, and we need to communicate with the js runtime. So that's why the code there is a bit different.