Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

online_editor: Add properties viewer #1677

Merged
merged 2 commits into from Sep 23, 2022
Merged

online_editor: Add properties viewer #1677

merged 2 commits into from Sep 23, 2022

Conversation

hunger
Copy link
Member

@hunger hunger commented Sep 22, 2022

Add a simple widget showing the properties for the current Element.

tronical
tronical reviewed Sep 23, 2022
View reviewed changes
tools/online_editor/src/editor_widget.ts Outdated Show resolved Hide resolved
tools/online_editor/src/properties_widget.ts Outdated Show resolved Hide resolved
tools/online_editor/src/lsp_integration.ts Outdated Show resolved Hide resolved
tools/online_editor/src/properties_widget.ts Outdated Show resolved Hide resolved
tools/online_editor/src/properties_widget.ts Outdated Show resolved Hide resolved
tools/online_editor/src/worker/lsp_worker.ts Outdated Show resolved Hide resolved
@hunger
online_editor: Add properties viewer
d0bf749 
Add a simple widget showing the properties for the current Element.
tronical
tronical approved these changes Sep 23, 2022
View reviewed changes
tools/online_editor/src/editor_widget.ts Outdated Show resolved Hide resolved
@hunger @tronical
Update tools/online_editor/src/editor_widget.ts
9d0f32e 
Co-authored-by: Simon Hausmann <hausmann@gmail.com>
ogoffart
ogoffart approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a quick overview, but i think it looks alright and it would be nice to merge this before the next nightly job so we can see it in action.

@hunger hunger merged commit fbce062 into slint-ui:master Sep 23, 2022
@hunger hunger deleted the oe_property_viewer branch September 23, 2022 15:18
@hunger
Copy link
Member Author

hunger commented Sep 23, 2022

@ogoffart: Done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hunger @tronical @ogoffart