Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for custom carousel widget #1739

Merged
merged 29 commits into from Oct 18, 2022
Merged

Conversation

FloVanGH
Copy link
Member

Add example with a custom carousel widget for rust, cpp and js

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe we should have a folder common to more demo to store the fonts?

Since there is no logic to this example, i wonder if it is a good idea to have a rust/cpp/node code, while just the .slint would suffice. On the other hand, it doesn't hurt to have it.

If you want the wasm demo to be compiled and uploaded, then you should also edit the .github/workflows/wasm_demo.yaml
I'm not sure we should do that since it has no UI. There can still be a demo using the previewer. (Same as the iot-dashboard)

examples/fancy_demo/main.slint Outdated Show resolved Hide resolved
examples/carousel/ui/icons/README.md Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@FloVanGH
Copy link
Member Author

Maybe we should have a folder common to more demo to store the fonts?

We can think about that. Also if we start using the same fonts and icons in the same example.

Since there is no logic to this example, i wonder if it is a good idea to have a rust/cpp/node code, while just the .slint would suffice. On the other hand, it doesn't hurt to have it.

I used this setup that you are able to run the carousel example also like this others described in the readme. And it can be used as based for someone new to Slint.

If you want the wasm demo to be compiled and uploaded, then you should also edit the .github/workflows/wasm_demo.yaml
I'm not sure we should do that since it has no UI. There can still be a demo using the previewer. (Same as the iot-dashboard)

For completeness I add it to the yaml file. But if wanted I can remove it.

@ogoffart
Copy link
Member

please squash and give an appropriate commit message when merging

@FloVanGH FloVanGH changed the title Florian/carousel example Add example for custom carousel widget Oct 18, 2022
@FloVanGH FloVanGH merged commit e5bf4c0 into master Oct 18, 2022
@FloVanGH FloVanGH deleted the florian/carousel-example branch October 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants