janitor: Some clippy fixes #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Jan 16, 2023
internal/core/layout.rs
Outdated
| if to_distribute <= 0. || max_grow <= 0. { | ||
| return Some(()); | ||
| } | ||
|
|
||
| let grow = if total_stretch <= 0. { | ||
| to_distribute | ||
| / (data.iter().filter(|it| A::can_grow(it) > 0 as _).count() as Coord) as f32 | ||
| to_distribute / (data.iter().filter(|it| A::can_grow(it) > 0 as _).count() as Coord) |
There was a problem hiding this comment.
the thing is that Coord can be f32 or i32 depending on the compile option, so lots of conversion are actually necessary.
There was a problem hiding this comment.
Very good point indeed, I'll just drop that for now. I do want the errors out of the way though.
These are reported as errors by clippy (nothing major IMHO), but they stop clippy from looking at all files, so let's get them out of the way.
hunger
force-pushed
the
clippy
branch
2 times, most recently
from
a3a4034
to
3afa8be
Compare
ogoffart
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.