Fix doc rendering of remaining callbacks #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tronical
commented
Mar 6, 2023
tronical
commented
- Don't show a literal underscore.
- Close the code fence so that the markdown link turns into a real link.
- Don't show a literal underscore. - Close the code fence so that the markdown link turns into a real link.
|
Do we really want the types to be in italic? |
ogoffart
approved these changes
Mar 6, 2023
|
I'm also not sure about the use of italic here. I hope that eventually we can generate these files from .slint files and then maybe we can use span tags and CSS to format these properly, and also generate links for every parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.