Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example that shows how to combine ffmpeg with Slint #2778

Merged
merged 3 commits into from Jun 1, 2023

Conversation

tronical
Copy link
Member

This is a minimal example, that can be used as basis to implement hardware acceleration for video playback later.

This is excluded from the CI right now as it would require installing ffmpeg, which may not be worth the hassle.

@ogoffart
Copy link
Member

This is excluded from the CI right now as it would require installing ffmpeg,

Is that not just a simple apt command on Linux?

@tronical
Copy link
Member Author

This is excluded from the CI right now as it would require installing ffmpeg,

Is that not just a simple apt command on Linux?

Yes, but it's slightly more complicated on Windows. If you have vcpkg setup, it's quite simple, but it will take a long time to build on Windows. There are pre-built DLLs that can also be downloaded and used. Maybe there's a GitHub action for it, I'll take a look.

@tronical
Copy link
Member Author

The existing GH action for ffmpeg doesn't instal DLLs & headers, so it can't be used. ffmpeg can be built from source with vcpkg, but it takes a long time. brew also works on macOS, but also takes a long time to download and install dependencies. So I've opted for a linux-only build in the CI.

@tronical tronical force-pushed the simon/ffmpeg branch 3 times, most recently from 7f3e638 to 2c151e4 Compare June 1, 2023 14:33
This is a minimal example, that can be used as basis to implement
hardware acceleration for video playback later.
Move the decoding and forwarding state into a struct, instead of keeping it in closure captures.
This way we can also make it generic over different output types.
@tronical tronical merged commit 6ece192 into master Jun 1, 2023
24 checks passed
@tronical tronical deleted the simon/ffmpeg branch June 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants