New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProgressIndicator widgets #2792
Conversation
FloVanGH
commented
May 30, 2023
- Add material ProgressIndicator
- Add fluent ProgressIndicator
- Add native ProgressIndicator
- Add ProgressIndicator documtentation
1a99268
to
724ebea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good. I'm unsure about the in-out
vs in
. What do you think?
Also API wise, I see that minimum
, maximum
, and value
are consistent with other controls, but I wonder if it would be better to have names that make more sense in the context of the progress. But ok, that's not too important.
API wise I'm somehow missing a text
. If I were to implement some kind of download dialog, I'd want to also show the progress in percent for example - or display the number of downloaded bytes. But I see that this isn't supported by material design or fluent. So I'd have to build it myself, and then it looks out of place again on the desktop.
Please add a ChangeLog entry.
To rename Yes fluent and material design |
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's go with this. We can do another round of API review before the next release, but I think this is good to merge - looking forward :)
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>