Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProgressIndicator widgets #2792

Merged
merged 10 commits into from May 31, 2023
Merged

Add ProgressIndicator widgets #2792

merged 10 commits into from May 31, 2023

Conversation

FloVanGH
Copy link
Member

  • Add material ProgressIndicator
  • Add fluent ProgressIndicator
  • Add native ProgressIndicator
  • Add ProgressIndicator documtentation

@FloVanGH FloVanGH requested a review from tronical May 30, 2023 09:32
@FloVanGH FloVanGH force-pushed the florian/progress-indicator branch from 1a99268 to 724ebea Compare May 30, 2023 09:34
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good. I'm unsure about the in-out vs in. What do you think?

Also API wise, I see that minimum, maximum, and value are consistent with other controls, but I wonder if it would be better to have names that make more sense in the context of the progress. But ok, that's not too important.

API wise I'm somehow missing a text. If I were to implement some kind of download dialog, I'd want to also show the progress in percent for example - or display the number of downloaded bytes. But I see that this isn't supported by material design or fluent. So I'd have to build it myself, and then it looks out of place again on the desktop.

Please add a ChangeLog entry.

docs/language/src/builtins/widgets.md Outdated Show resolved Hide resolved
docs/language/src/builtins/widgets.md Outdated Show resolved Hide resolved
docs/language/src/builtins/widgets.md Outdated Show resolved Hide resolved
docs/language/src/builtins/widgets.md Outdated Show resolved Hide resolved
internal/backends/qt/qt_widgets/progress_indicator.rs Outdated Show resolved Hide resolved
internal/backends/qt/qt_widgets/progress_indicator.rs Outdated Show resolved Hide resolved
@FloVanGH
Copy link
Member Author

Looks overall good. I'm unsure about the in-out vs in. What do you think?

Also API wise, I see that minimum, maximum, and value are consistent with other controls, but I wonder if it would be better to have names that make more sense in the context of the progress. But ok, that's not too important.

API wise I'm somehow missing a text. If I were to implement some kind of download dialog, I'd want to also show the progress in percent for example - or display the number of downloaded bytes. But I see that this isn't supported by material design or fluent. So I'd have to build it myself, and then it looks out of place again on the desktop.

Please add a ChangeLog entry.

To rename value to progress makes totally sense.

Yes fluent and material design ProgressBars are without text.

FloVanGH and others added 5 commits May 30, 2023 19:11
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's go with this. We can do another round of API review before the next release, but I think this is good to merge - looking forward :)

CHANGELOG.md Outdated Show resolved Hide resolved
FloVanGH and others added 2 commits May 31, 2023 09:19
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
@FloVanGH FloVanGH merged commit 9e267bc into master May 31, 2023
24 checks passed
@FloVanGH FloVanGH deleted the florian/progress-indicator branch May 31, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants