Add support for italic text rendering #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
force-pushed
the
simon/text-italic
branch
2 times, most recently
from
af54cee
to
1086b00
Compare
ogoffart
approved these changes
May 30, 2023
| @@ -17,6 +17,38 @@ pub struct FontDatabase { | |||
| target_arch = "wasm32" | |||
| )))] | |||
| pub fontconfig_fallback_families: Vec<String>, | |||
| // Default font famiilies to use instead of SansSerif when SLINT_DEFAULT_FONT env var is set. | |||
There was a problem hiding this comment.
It's a very emotional family :-)
There was a problem hiding this comment.
Do I read the patch correctly that bold is supported now? If yes it'd be nice to be tested as well
There was a problem hiding this comment.
It's not quite there yet. I added the weight because... it was right there in my face :-). But it's not matched for yet. But you're right, might as well do it in one shot. I need to fix the screenshot bit anyway.
…nput` This is implemented for FemtoVG, Skia, and Qt.
Centralize also fontdb::Query creation and family fallback handling in sharedfontdb. This way SLINT_DEFAULT_FONT also works for the femtovg renderer.
tronical
force-pushed
the
simon/text-italic
branch
from
1086b00
to
f830273
Compare
…p font path In the screenshot tests this works by setting SLINT_DEFAULT_FONT to pointer to a directory, instead of a file. We then load all fonts in that directory and consider their families the default unless a family is specified. This way for "Noto Sans" a regular as well as an italic version is registered in fontdb and returned in the list of font fallback ids. embed_glyphs in the compiler then embeds those variants and we find them at run-time.
tronical
force-pushed
the
simon/text-italic
branch
from
f830273
to
4a0fba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this is just a boolean property - that's the API that's easiest to learn and use. If we implement a generic style enum / mask later, then we can map that in the compiler to the corresponding expression.
Closes #2317