Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janitor: Update to Corrosion 0.4.0 release #2807

Merged
merged 2 commits into from Jun 3, 2023
Merged

Conversation

tronical
Copy link
Member

@tronical tronical commented Jun 2, 2023

No description provided.

@tronical tronical added this to the 1.1 milestone Jun 2, 2023
@ogoffart
Copy link
Member

ogoffart commented Jun 2, 2023

CI is failling on Windows with

The following tests FAILED:
	  1 - test_datastructures (Exit code 0xc0000135)
	  2 - test_interpreter (Exit code 0xc0000135)
	  3 - test_properties (Exit code 0xc0000135)
	  4 - test_eventloop (Exit code 0xc0000135)
	  5 - test_models (Exit code 0xc0000135)
	  6 - test_window (Exit code 0xc0000135)

That exit code seems to be STATUS_DLL_NOT_FOUND, or 'A dependent dll was not found' (according to google search leading to stack overflow)

It worked with the v0.4-beta2 and the most likely commit is therefore corrosion-rs/corrosion@de3f2f5

CC: @jschwe any idea why our test can't find the dll with the release while it worked with the beta2?

@jschwe
Copy link
Contributor

jschwe commented Jun 3, 2023

Would it be possible to run the CI job with Rust 1.69, just to confirm it's not related to rust 1.70? Rust 1.70 also added a new dependency on windows , which could also be related.

@jschwe
Copy link
Contributor

jschwe commented Jun 3, 2023

Ah, I see you are setting -DCMAKE_BUILD_TYPE=Debug even for multi config generators.
I guess I'll have to extend corrosion-rs/corrosion@de3f2f5 to explicitly check for multi-config generators and not rely on CMAKE_BUILD_TYPE being set implying a single config generator.

Okay, I forgot to promote a variable to CACHE, so it wasn't set anymore when corrosion_import_crate was called.

api/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@ogoffart ogoffart merged commit 7485fd6 into master Jun 3, 2023
24 checks passed
@ogoffart ogoffart deleted the simon/corrosion-update branch June 3, 2023 10:39
@ogoffart ogoffart mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants