Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: jobs for translations #2826

Merged
merged 1 commit into from Jun 6, 2023
Merged

CI: jobs for translations #2826

merged 1 commit into from Jun 6, 2023

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented Jun 5, 2023

No description provided.

@ogoffart ogoffart requested a review from tronical June 5, 2023 17:07
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding those guards that allow the commit/push to fail without the job failing. Just a detail though:)

# Copyright © SixtyFPS GmbH <info@slint-ui.com>
# SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-commercial

# Build various demo binaries, c++ packages and documentation and publish them on the website
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it came from another file.

msgfmt $po/gallery.po -o $po/gallery.mo
done
- name: commit
run: "git commit -a -m 'Translations: Extract strings' --author 'Update Translations Bot <noreply@slint-ui.com>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the job is called update translations then perhaps the commit message should say the same?

@ogoffart ogoffart merged commit 15b120d into master Jun 6, 2023
1 of 14 checks passed
@ogoffart ogoffart deleted the olivier/translations branch June 6, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants