Clean up the Skia renderer API #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I disagree, I think it should take The reason why other crate on the ecosystem are not using that yet is because it is fairly new. With that, it doesn't need to be unsafe. |
|
Sounds good to me, thanks for the hint. |
tronical
force-pushed
the
simon/rwh-renderer-cleanup
branch
from
e8405e5
to
a2940d3
Compare
ogoffart
reviewed
Jun 7, 2023
| @@ -38,7 +39,7 @@ impl super::Surface for MetalSurface { | |||
| layer.set_drawable_size(CGSize::new(size.width as f64, size.height as f64)); | |||
|
|
|||
| unsafe { | |||
There was a problem hiding this comment.
detail: the unsafe could probably have a smaller scope (feel free to ignore)
tronical
force-pushed
the
simon/rwh-renderer-cleanup
branch
from
a2940d3
to
f57f133
Compare
ogoffart
approved these changes
Jun 7, 2023
Accept display and window handles with life time, instead of &dyn HasRaw*Handle.
tronical
force-pushed
the
simon/rwh-renderer-cleanup
branch
from
f57f133
to
ba15a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept raw display and window handles, instead of &dyn HasRaw*Handle.
This is consistent with other crates in the Rust ecosystem. Consequently the accepting functions are marked unsafe, as the
API can't guarantee that the handles remain valid.