Make WindowAdaptor::request_redraw public #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
commented
Jun 13, 2023
| @@ -16,7 +16,6 @@ use i_slint_core::{ | |||
| platform::PlatformError, | |||
| renderer::RendererSealed, | |||
| software_renderer::{LineBufferProvider, MinimalSoftwareWindow}, | |||
| window::WindowAdapterInternal, | |||
There was a problem hiding this comment.
Because now, the call to request_redraw() no longer use the one from WindowAdapterInternal but use the one from the Window through Deref
| @@ -538,10 +540,10 @@ impl WindowInner { | |||
| /// Sets the focus to the item pointed to by item_ptr. This will remove the focus from any | |||
| /// currently focused item. | |||
| pub fn set_focus_item(&self, focus_item: &ItemRc) { | |||
| let old = self.take_focus_item(); | |||
| let new = self.move_focus(focus_item.clone(), next_focus_item); | |||
There was a problem hiding this comment.
I noticed this bug because now MinimalSoftwareWindow no longer implements WindowAdapterInternal. So the screenshot test wouldn't render the cursor on the line edit since it no longer had the focus.
There was a problem hiding this comment.
Yay for the screenshot tests:)
tronical
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.