Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Minor fixes #2961

Merged
merged 2 commits into from Jun 22, 2023
Merged

doc: Minor fixes #2961

merged 2 commits into from Jun 22, 2023

Conversation

tronical
Copy link
Member

No description provided.

@tronical tronical requested a review from ogoffart June 22, 2023 09:44
/// current during any of the invocations of the callback set on [`Window::set_rendering_notifier()`].
/// OpenGL contexts between instances of [`slint::Window`] are not sharing resources. Consequently
/// [`slint::Image`] objects created from borrowed OpenGL textures cannot be shared between
/// current during any of the invocations of the callback set on `Window::set_rendering_notifier()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't the link working?
You can also add ](crate::api::Window

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thank you!! I always forget this special syntax. Yeah, it's the crate::api:: that I don't want to have visible, but your trick gives the perfect result. Will fix.

Elaborate how to call this function safely, and copy the same description to the C++ docs.
@tronical tronical merged commit aa41277 into master Jun 22, 2023
25 of 26 checks passed
@tronical tronical deleted the simon/doc-fixes branch June 22, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants