Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update royalty free license to 1.1 #2994

Merged
merged 8 commits into from Jul 10, 2023

Conversation

aurindam
Copy link
Member

No description provided.

@hunger
Copy link
Member

hunger commented Jun 27, 2023

I'd suggest waiting for a few days for more feedback to come in before doing such a bulk change.

@hunger
Copy link
Member

hunger commented Jun 27, 2023

You need to remove LicenseRef-Slint-Royalty-free-1.0 as it is not used anymore.

@tronical
Copy link
Member

You need to remove LicenseRef-Slint-Royalty-free-1.0 as it is not used anymore.

We link to it from the blog post and perhaps other places :(. Removing it breaks those links.

@ogoffart
Copy link
Member

We link to it from the blog post and perhaps other places :(. Removing it breaks those links.

I suggest we keep it for at least a few month.
In the mean time, we can also fix our links by linking to the new one

@hunger
Copy link
Member

hunger commented Jun 27, 2023

We can copy the 1.0 version of the license to the website and link to it there. Let's keep the website self-contained, too many links between unrelated components in separate repos are always hard to keep alive:-)

Reuse will flag that unused license in our tree each time its run -- and its part of our CI setup. So we would need to disable that if we want to keep the license in the same place in our source tree.

@ogoffart
Copy link
Member

We can copy the 1.0 version of the license to the website and link to it there

No, the point to keep it is only to get the old links working.

Reuse will flag that unused license in our tree each time its run -- and its part of our CI setup. So we would need to disable that if we want to keep the license in the same place in our source tree.

Yes, can we disable that? (how about working around it by having at least one dummy file using that license)

@hunger
Copy link
Member

hunger commented Jun 27, 2023

A dummy file would work I guess.

@hunger
Copy link
Member

hunger commented Jun 27, 2023

Just fix the links to point to the license in th 1.1.0 tag?

@aurindam aurindam force-pushed the auri-update-royalty-free-license-1.1 branch from dfffea4 to d551834 Compare July 7, 2023 09:03
@aurindam aurindam requested a review from hunger July 10, 2023 07:19
internal/dummy/dummy.rs Outdated Show resolved Hide resolved
@tronical tronical force-pushed the auri-update-royalty-free-license-1.1 branch from 31fe9e2 to 75d73f2 Compare July 10, 2023 07:51
@tronical tronical merged commit 5a4a7fe into master Jul 10, 2023
26 checks passed
@tronical tronical deleted the auri-update-royalty-free-license-1.1 branch July 10, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants