TextEdit: Discard the preedit when focus change or other text is enter #3000
Conversation
Otherwise we end up with outdated pre-edit data if we change focus while editing. Note: Qt doas actually send a "commit" event when the focus change (but of course that does not happen when changing the focus within slint) But firefox does discard the preedit when loosing the focus. CC #1925
|
Please note that i don't really know what i'm doing. |
|
I never used IME either (nor do I speak a language that needs IME, so even when I bring up IME, I have no idea what the desired behavior is), but I would expect some UI to come up. Won't that take away focus from our UI? Can that loss of focus interfere with the preedit text now? |
| self.preedit_text.set(Default::default()); | ||
| self.preedit_selection_start.set(0); | ||
| self.preedit_selection_end.set(0); |
There was a problem hiding this comment.
This might or might not help, but it carries the risk of the input method being out of sync with the state that we think it is in. When the text of the input field changes, we should inform the input method about what the new text is. Qt has APIs for that, winit unfortunately doesn't.
no it won't, if it did, the preedit would never reach the right line edit. (the UI that comes up don't have the focus iself) |
Co-authored-by: Simon Hausmann <simon.hausmann@slint-ui.com>
Otherwise we end up with outdated pre-edit data if we change focus while editing.
Note: Qt doas actually send a "commit" event when the focus change (but of course that does not happen when changing the focus within slint)
But firefox does discard the preedit when loosing the focus.
CC #1925