C++: Add slint::Window::scale_factor() getter #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll add a test that verifies the value is greater than zero. |
ogoffart
approved these changes
Jun 28, 2023
ogoffart
approved these changes
Jun 28, 2023
|
|
||
| TEST_CASE("Window Scale Factory Existence") | ||
| { | ||
| using namespace slint::interpreter; |
There was a problem hiding this comment.
The window.cpp test is build unconditionally regardless of SLINT_FEATURE_INTERPRETER
So this should probably be fixed in the tests/CMakeLists.txt (But that's not a new problem)
There was a problem hiding this comment.
Good point, I'll push a change to master for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3003