Fix support normalized ranges for Slider with Qt style #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Jun 28, 2023
Comment on lines
+43
to
+47
| option.maximum = maximum * 1024; | ||
| option.minimum = minimum * 1024; | ||
| int value = float_value * 1024; |
The OpenGL Texture import example uses a Slider in the range 0..1. That doesn't work with QStyleOptionSlider out of the box because it's using integer values.
tronical
force-pushed
the
simon/qt-slider-range
branch
from
358d2b9
to
dea4a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenGL Texture import example uses a Slider in the range 0..1. That doesn't work with QStyleOptionSlider out of the box because it's
using integer values.