Fix panic in the software renderer with clipped text and scale factor #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Jul 6, 2023
We ended rendering glyphs with empty or even negative size, causing panics down the line. I added a way in the screenshot tester to change the scale factor CC: #2957
In some case, when the clip is, eg on a 0.25 of a pixel, but the offset is 0.75, (such that the begining of the glyph starts at 0.5) difference in rounding in different computation can result in a width which is one pixel bigger than the source image. I couldn't reproduce this in a testcase, but this can be reproduced while resizing or scrolling through a TextEdit I think this fixes #2957 The panic fixed by this commit looks like this: ``` thread 'main' panicked at 'index out of bounds: the len is 131 but the index is 131', /home/olivier/slint/internal/core/software_renderer/draw_functions.rs:81:19 stack backtrace: 3: i_slint_core::software_renderer::draw_functions::draw_texture_line at ./internal/core/software_renderer/draw_functions.rs:81:19 4: <i_slint_core::software_renderer::RenderToBuffer<T> as i_slint_core::software_renderer::ProcessScene>::process_shared_image_buffer at ./internal/core/software_renderer.rs:1023:13 5: i_slint_core::software_renderer::SceneBuilder<T>::draw_text_paragraph::{{closure}} at ./internal/core/software_renderer.rs:1404:37 6: i_slint_core::textlayout::TextParagraphLayout<Font>::layout_lines::{{closure}} at ./internal/core/textlayout.rs:219:17 ```
ogoffart
force-pushed
the
olivier/swrenderer
branch
from
5f97ac0
to
e1e271a
Compare
|
I added more commits that fixes more bugs. |
tronical
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended rendering glyphs with empty or even negative size, causing panics down the line.
I added a way in the screenshot tester to change the scale factor
CC: #2957